Changeset 93835 in webkit for trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

Timestamp:

Aug 25, 2011, 4:30:14 PM (14 years ago)

Author:

[email protected]

Message:

Unzip initialization lists and constructors in JSCell hierarchy (1/7)
​https://bugs.webkit.org/show_bug.cgi?id=66827

Patch by Mark Hahnenberg <​[email protected]> on 2011-08-25
Reviewed by Geoffrey Garen.

Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors. Part of a larger refactoring to "unzip" initialization
lists and constructor bodies. Also renamed JSCell's constructorBody() method
to finishCreation().

• runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):

• runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):

• runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

• runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):

• runtime/JSObject.h:

(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):

• runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::constructorBody):

• runtime/JSString.h:

(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):

• runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):

• runtime/RegExp.h:
• runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):

• runtime/Structure.cpp:

(JSC::Structure::Structure):

• runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

• runtime/StructureChain.h:

(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):

File:

• trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

@@ -25 +25 @@
 
 #include "JSCell.h"
+#include "JSValue.h"
 #include "CallFrame.h"
 #include "Structure.h"
@@ -51 +52 @@
         }
 
+    protected:
+        void finishCreation(ExecState* exec, JSValue value)
+        {
+            Base::finishCreation(exec->globalData());
+            m_value.set(exec->globalData(), this, value);
+            ASSERT(!value.isCell());
+        }
+
     private:
         JSAPIValueWrapper(ExecState* exec, JSValue value)
             : JSCell(exec->globalData(), exec->globalData().apiWrapperStructure.get())
         {
-            m_value.set(exec->globalData(), this, value);
-            ASSERT(!value.isCell());
+            finishCreation(exec, value);
         }