Changeset 93920 in webkit for trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

Timestamp:

Aug 26, 2011, 3:32:53 PM (14 years ago)

Author:

[email protected]

Message:

Unzip initialization lists and constructors in JSCell hierarchy (2/7)
​https://bugs.webkit.org/show_bug.cgi?id=66957

Patch by Mark Hahnenberg <​[email protected]> on 2011-08-26
Reviewed by Darin Adler.

Completed the second level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

• runtime/Executable.h:

(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::create):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):

• runtime/GetterSetter.h:

(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):

• runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::create):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):

• runtime/JSObject.h:

(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::JSObject):

• runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):

• runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::create):

• runtime/RegExp.cpp:

(JSC::RegExp::RegExp):
(JSC::RegExp::createWithoutCaching):

• runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::create):

• runtime/Structure.cpp:

(JSC::Structure::Structure):

• runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::finishCreation):
(JSC::Structure::createStructure):

• runtime/StructureChain.cpp:

(JSC::StructureChain::StructureChain):

• runtime/StructureChain.h:

(JSC::StructureChain::create):

File:

• trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSAPIValueWrapper.h

@@ -49 +49 @@
         static JSAPIValueWrapper* create(ExecState* exec, JSValue value) 
         {
-            return new (allocateCell<JSAPIValueWrapper>(*exec->heap())) JSAPIValueWrapper(exec, value);
+            JSAPIValueWrapper* wrapper = new (allocateCell<JSAPIValueWrapper>(*exec->heap())) JSAPIValueWrapper(exec);
+            wrapper->finishCreation(exec, value);
+            return wrapper;
         }
 
@@ -61 +63 @@
 
     private:
-        JSAPIValueWrapper(ExecState* exec, JSValue value)
+        JSAPIValueWrapper(ExecState* exec)
             : JSCell(exec->globalData(), exec->globalData().apiWrapperStructure.get())
         {
-            finishCreation(exec, value);
         }