Changeset 95310 in webkit for trunk/Source/JavaScriptCore/runtime/Lookup.h

Timestamp:

Sep 16, 2011, 11:50:04 AM (14 years ago)

Author:

[email protected]

Message:

DFG JIT should inline Math.abs
​https://bugs.webkit.org/show_bug.cgi?id=68227

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.

On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.

Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h

This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.

• JavaScriptCore.xcodeproj/project.pbxproj:
• create_hash_table:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):

• dfg/DFGIntrinsic.h: Added.
• dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):

• dfg/DFGNode.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

• jit/JITStubs.h:
• runtime/DateInstanceCache.h:
• runtime/Executable.cpp:

(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):

• runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

• runtime/JSGlobalData.h:
• runtime/Lookup.cpp:

(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):

• runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

Source/WebCore:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.

• CMakeLists.txt:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

Source/WebKit:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

• CMakeLists.txt:

Source/WebKit2:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

• CMakeLists.txt:

File:

• trunk/Source/JavaScriptCore/runtime/Lookup.h (modified) (6 diffs)

trunk/Source/JavaScriptCore/runtime/Lookup.h

@@ -23 +23 @@
 
 #include "CallFrame.h"
+#include "DFGIntrinsic.h"
 #include "Identifier.h"
 #include "JSGlobalObject.h"
@@ -45 +46 @@
 #if ENABLE(JIT)
         ThunkGenerator generator;
+#if ENABLE(DFG_JIT)
+        DFG::Intrinsic intrinsic;
+#endif
 #endif
     };
@@ -59 +63 @@
 #if ENABLE(JIT)
                         , ThunkGenerator generator = 0
+#if ENABLE(DFG_JIT)
+                        , DFG::Intrinsic intrinsic = DFG::NoIntrinsic
+#endif
 #endif
                         )
@@ -68 +75 @@
 #if ENABLE(JIT)
             m_u.function.generator = generator;
+#if ENABLE(DFG_JIT)
+            m_u.function.intrinsic = intrinsic;
+#endif
 #endif
             m_next = 0;
@@ -79 +89 @@
 #if ENABLE(JIT)
         ThunkGenerator generator() const { ASSERT(m_attributes & Function); return m_u.function.generator; }
+        DFG::Intrinsic intrinsic() const
+        {
+            ASSERT(m_attributes & Function);
+#if ENABLE(DFG_JIT)
+            return m_u.function.intrinsic;
+#else
+            return DFG::NoIntrinsic;
+#endif
+        }
 #endif
         NativeFunction function() const { ASSERT(m_attributes & Function); return m_u.function.functionValue; }
@@ -105 +124 @@
 #if ENABLE(JIT)
                 ThunkGenerator generator;
+#if ENABLE(DFG_JIT)
+                DFG::Intrinsic intrinsic;
+#endif
 #endif
             } function;