Changeset 95318 in webkit for trunk/Source/JavaScriptCore/runtime/Lookup.h

Timestamp:

Sep 16, 2011, 1:32:15 PM (14 years ago)

Author:

[email protected]

Message:

Rationalize JSObject::putDirect* methods
​https://bugs.webkit.org/show_bug.cgi?id=68274

Reviewed by Sam Weinig.

Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.

• JavaScriptCore.exp:
• jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject::addFunction):

• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

• runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):

• runtime/JSObject.h:

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):

• runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

• runtime/Lookup.h:

(JSC::lookupPut):

File:

• trunk/Source/JavaScriptCore/runtime/Lookup.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Lookup.h

@@ -334 +334 @@
         if (entry->attributes() & Function) { // function: put as override property
             if (LIKELY(value.isCell()))
-                thisObj->putDirectFunction(exec->globalData(), propertyName, value.asCell());
+                thisObj->putDirect(exec->globalData(), propertyName, value.asCell());
             else
                 thisObj->putDirect(exec->globalData(), propertyName, value);