Skip to content

Do not explode AARs even if gradle project is not enabled #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

doterax
Copy link

@doterax doterax commented Jan 20, 2023

Fixes #584 #287

@google-cla
Copy link

google-cla bot commented Jan 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ievgenmukhin
Copy link

This fix will be extremely helpful for our projects.

@chkuang-g
Copy link
Collaborator

Hey @doterax

Sorry have to revert this change in #612 since it is failing tests.

Let me put together a new PR

@chkuang-g
Copy link
Collaborator

Here is the new PR. I will add you guys to review and wait for a week or two for your feedback :)

@doterax
Copy link
Author

doterax commented Apr 16, 2023

I reviewed new PR

@googlesamples googlesamples locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] disabling Explore AAR still downloads and modifies AARs
3 participants